-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Bugfix] Fix environment variable setting in CPU Dockerfile #21730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jiang1.li <jiang1.li@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses the issue of LD_PRELOAD not being set reliably for docker exec commands by switching from modifying .bashrc to using a multi-stage Docker build with ENV instructions. This is a much more robust approach.
My review focuses on a potential security and correctness issue with how the LD_PRELOAD variable is constructed in the new stages. The suggestions aim to make the implementation safer and cleaner by avoiding a leading colon in the environment variable.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: x22x22 <wadeking@qq.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com>
…ject#21730) Signed-off-by: jiang1.li <jiang1.li@intel.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
After #21343
LD_PRELOADis not effective in such usage:It causes the serving test in CPU CI timeouts. This PR fixed this problem with a more robust multi-stage build style.
Test Plan
Test Result
(Optional) Documentation Update