Skip to content

[V0 deprecation] Guided decoding #21347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

rzabarazesh
Copy link
Collaborator

@rzabarazesh rzabarazesh commented Jul 22, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Remove v0 guided decoding code.

Test Plan

Test Result

(Optional) Documentation Update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the v0 guided decoding functionality, which simplifies the codebase significantly. The changes mostly consist of deleting old files and removing references to the deprecated v0 guided decoding API, which has been done correctly across the board.

However, I've identified a critical inconsistency regarding the outlines guided decoding backend. While its implementation has been removed, it's still listed as a valid backend in the configuration, leading to contradictory behavior in the tests. My review includes a detailed comment and a suggestion to resolve this ambiguity.

@rzabarazesh rzabarazesh force-pushed the guided_decoding_deprecation_v0 branch from 8be0e76 to 6019893 Compare July 22, 2025 04:08
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@rzabarazesh rzabarazesh force-pushed the guided_decoding_deprecation_v0 branch from 6019893 to 6eaa86b Compare July 22, 2025 06:20
@mergify mergify bot added the ci/build label Jul 22, 2025
@rzabarazesh rzabarazesh force-pushed the guided_decoding_deprecation_v0 branch from 6eaa86b to b594e93 Compare July 22, 2025 06:22
@rzabarazesh rzabarazesh changed the title Guided decoding v0 deprecation [Core] Guided decoding v0 deprecation Jul 22, 2025
@rzabarazesh rzabarazesh force-pushed the guided_decoding_deprecation_v0 branch from b594e93 to 0d62990 Compare July 22, 2025 06:39
@rzabarazesh rzabarazesh marked this pull request as ready for review July 22, 2025 14:09
@mergify mergify bot removed the needs-rebase label Jul 23, 2025
Copy link

mergify bot commented Jul 23, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @rzabarazesh.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 23, 2025
@rzabarazesh rzabarazesh force-pushed the guided_decoding_deprecation_v0 branch 2 times, most recently from c2d26ac to 85d22e4 Compare July 24, 2025 05:48
@mergify mergify bot removed the needs-rebase label Jul 24, 2025
@rzabarazesh rzabarazesh force-pushed the guided_decoding_deprecation_v0 branch from 85d22e4 to 88eb479 Compare July 24, 2025 05:53
@rzabarazesh
Copy link
Collaborator Author

Doesn't this overlap with #20928? cc @aarnphm

Unfortunately I didn't see #20928 as this task was unclaimed. This PR should cover everything in #20928 as well as some missing integration points (llm_engine.py, etc) and broken tests.

Copy link

mergify bot commented Jul 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @rzabarazesh.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 24, 2025
@hmellor hmellor removed the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2025
@hmellor
Copy link
Member

hmellor commented Jul 24, 2025

I've pushed a few tweaks and removed ready until we feel it's ready for merging

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too mant relevant tests have been deleted/disabled because of erroneous edits made to LLMEngine. These bad edits removed support for logit_bias and bad_words in V0 and deleted the corresponding tests even if they were still relevant for V1.

@rzabarazesh
Copy link
Collaborator Author

rzabarazesh commented Jul 24, 2025

Too mant relevant tests have been deleted/disabled because of erroneous edits made to LLMEngine. These bad edits removed support for logit_bias and bad_words in V0 and deleted the corresponding tests even if they were still relevant for V1.

Thank you for updating the PR @hmellor. I thought we wanted to remove logit_bias and bad_words in v0 as well.
Do you know why test_guided_generate is failing now? Should we skip it for V0?

@hmellor
Copy link
Member

hmellor commented Jul 24, 2025

I suppose ultimately we want to remove all of V0, but removing logit_bias and bad_words in this PR meant touching more tests to disable them in V0 (hence why I started to revert those changes).

@WoosukKwon should we also be removing logit_bias and bad_words in this PR?

@hmellor
Copy link
Member

hmellor commented Jul 24, 2025

Do you know why test_guided_generate is failing now? Should we skip it for V0?

I didn't spend much time looking into those ones. I added them back so that they could be run on V1. We could change the buildkite pipeline to only run this file in V1?

@WoosukKwon
Copy link
Collaborator

should we also be removing logit_bias and bad_words in this PR?

I'm ok with either, as long as these features are supported and tested in V1. V0 is officially deprecated anyways.

rzabarazesh and others added 11 commits July 24, 2025 18:01
Signed-off-by: Reza Barazesh <rezabarazesh@meta.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…e V1 compatible

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Reza Barazesh <rezabarazesh@meta.com>
@rzabarazesh rzabarazesh force-pushed the guided_decoding_deprecation_v0 branch from 6dc984c to 9d15988 Compare July 25, 2025 01:05
@mergify mergify bot removed the needs-rebase label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants