-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[V0 deprecation] Guided decoding #21347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[V0 deprecation] Guided decoding #21347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the v0 guided decoding functionality, which simplifies the codebase significantly. The changes mostly consist of deleting old files and removing references to the deprecated v0 guided decoding API, which has been done correctly across the board.
However, I've identified a critical inconsistency regarding the outlines
guided decoding backend. While its implementation has been removed, it's still listed as a valid backend in the configuration, leading to contradictory behavior in the tests. My review includes a detailed comment and a suggestion to resolve this ambiguity.
8be0e76
to
6019893
Compare
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
6019893
to
6eaa86b
Compare
6eaa86b
to
b594e93
Compare
b594e93
to
0d62990
Compare
This pull request has merge conflicts that must be resolved before it can be |
c2d26ac
to
85d22e4
Compare
85d22e4
to
88eb479
Compare
This pull request has merge conflicts that must be resolved before it can be |
I've pushed a few tweaks and removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too mant relevant tests have been deleted/disabled because of erroneous edits made to LLMEngine
. These bad edits removed support for logit_bias
and bad_words
in V0 and deleted the corresponding tests even if they were still relevant for V1.
Thank you for updating the PR @hmellor. I thought we wanted to remove logit_bias and bad_words in v0 as well. |
I suppose ultimately we want to remove all of V0, but removing logit_bias and bad_words in this PR meant touching more tests to disable them in V0 (hence why I started to revert those changes). @WoosukKwon should we also be removing logit_bias and bad_words in this PR? |
I didn't spend much time looking into those ones. I added them back so that they could be run on V1. We could change the buildkite pipeline to only run this file in V1? |
I'm ok with either, as long as these features are supported and tested in V1. V0 is officially deprecated anyways. |
Signed-off-by: Reza Barazesh <rezabarazesh@meta.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…e V1 compatible Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Reza Barazesh <rezabarazesh@meta.com>
6dc984c
to
9d15988
Compare
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Remove v0 guided decoding code.
Test Plan
Test Result
(Optional) Documentation Update