Skip to content

Add docstrings to url_schemes.py to improve readability #20545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

windsonsea
Copy link
Contributor

@windsonsea windsonsea commented Jul 7, 2025

Add detailed docstrings:

  • Added high-level explanation of the plugin’s purpose.
  • Documented supported GitHub shorthand link formats:
    • gh-issue
    • gh-pr
    • gh-project
    • gh-dir
    • gh-file
  • Described the logic of inline and auto-link transformations.
  • Included type hints and return type annotations.
  • No logic or behavior changes were introduced.

These updates help new contributors understand the plugin more quickly.

@windsonsea windsonsea requested a review from hmellor as a code owner July 7, 2025 06:12
Copy link

github-actions bot commented Jul 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @windsonsea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses entirely on improving the documentation and readability of the url_schemes.py file, which contains a custom MkDocs plugin hook. My aim was to make the code easier to understand for new contributors and future maintainers by adding detailed docstrings, inline comments, and type hints, without introducing any changes to the existing logic or behavior.

Highlights

  • Documentation Enhancement: Added a comprehensive docstring to the on_page_markdown function in url_schemes.py, detailing its purpose as a custom MkDocs plugin hook for rewriting GitHub shorthand links.
  • Clarity on Link Formats: The new docstring explicitly lists and explains the supported GitHub shorthand link formats, such as gh-issue, gh-pr, gh-project, gh-dir, and gh-file, along with examples of their transformation.
  • Internal Function Documentation: Docstrings were added to the replace_inline_link and replace_auto_link helper functions, clarifying their roles in processing different types of GitHub shorthand links.
  • Code Readability: Inline comments were added to explain key sections of the code, such as the urls mapping, the regular expression for shorthand links, and the final replacement steps.
  • Type Hinting: A return type annotation (-> str) was added to the on_page_markdown function signature for improved type clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the readability of url_schemes.py by adding comprehensive docstrings and comments. The documentation is clear and helpful for understanding the script's functionality. I've made one suggestion to correct an example in the main docstring for consistency and accuracy. Great work on enhancing the project's documentation!

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this documentation!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 7, 2025 06:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 7, 2025
@DarkLight1337
Copy link
Member

Can you fix pre-commit?

@windsonsea
Copy link
Contributor Author

oh, let me try.

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
auto-merge was automatically disabled July 7, 2025 07:15

Head branch was pushed to by a user without write access

@windsonsea
Copy link
Contributor Author

Hi @DarkLight1337, thanks for your guidance. Seems the pre-commit is fixed now.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 7, 2025 08:30
@DarkLight1337 DarkLight1337 merged commit 1fd471e into vllm-project:main Jul 7, 2025
45 checks passed
huydhn pushed a commit to huydhn/vllm that referenced this pull request Jul 8, 2025
Chen-zexi pushed a commit to Chen-zexi/vllm that referenced this pull request Jul 13, 2025
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Jul 15, 2025
…#20545)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
@windsonsea windsonsea deleted the urldoc branch July 23, 2025 07:28
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
…#20545)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
…#20545)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants