[Misc] Set the minimum openai version #20539
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jeejeelee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the minimum required version of the openai package to 1.87.0. This change ensures compatibility with recent updates in the vllm project, specifically related to the merging of pull request #20504.
Highlights
- Dependency Update: The minimum supported version of the
openaipackage has been bumped from 1.52.0 to 1.87.0 inrequirements/common.txt.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the minimum required version for the openai package to 1.87.0 in requirements/common.txt. This is a necessary change to support features introduced in a previous pull request. I've added one suggestion to update the inline comment to reflect the reason for this version bump, which will improve maintainability.
requirements/common.txt
Outdated
| @@ -13,7 +13,7 @@ tokenizers >= 0.21.1 # Required for fast incremental detokenization. | |||
| protobuf # Required by LlamaTokenizer. | |||
| fastapi[standard] >= 0.115.0 # Required by FastAPI's form models in the OpenAI API server's audio transcriptions endpoint. | |||
| aiohttp | |||
| openai >= 1.52.0, <= 1.90.0 # Ensure modern openai package (ensure types module present and max_completion_tokens field support) | |||
| openai >= 1.87.0, <= 1.90.0 # Ensure modern openai package (ensure types module present and max_completion_tokens field support) | |||
There was a problem hiding this comment.
For better maintainability, it's good practice to keep comments explaining version pins up-to-date. The current comment seems to refer to the reason for the previous minimum version (1.52.0). Since this change is prompted by another PR, could you update the comment to reflect the new reason or reference the PR that requires this update? This will help future developers understand the dependency constraint.
openai >= 1.87.0, <= 1.90.0 # Ensure modern openai package; min version raised for features from PR #20504
requirements/common.txt
Outdated
| @@ -13,7 +13,7 @@ tokenizers >= 0.21.1 # Required for fast incremental detokenization. | |||
| protobuf # Required by LlamaTokenizer. | |||
| fastapi[standard] >= 0.115.0 # Required by FastAPI's form models in the OpenAI API server's audio transcriptions endpoint. | |||
| aiohttp | |||
| openai >= 1.52.0, <= 1.90.0 # Ensure modern openai package (ensure types module present and max_completion_tokens field support) | |||
| openai >= 1.87.0, <= 1.90.0 # Ensure modern openai package (ensure types module present and max_completion_tokens field support) | |||
There was a problem hiding this comment.
Can you update the comment to mention Responses API instead?
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
github-actions
bot
added
the
ready
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
After merging #20504 ,the minimum openai version is
1.87.0Test Plan
Test Result
(Optional) Documentation Update