-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Bugfix] Build moe_data for both sm100 and sm90 #20086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mgoin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug where the moe_data
component, essential for Mixture-of-Experts (MoE) kernels, was not being correctly built for Blackwell (sm100) architectures. The changes ensure that moe_data
is properly compiled and enabled for both Hopper (sm90) and Blackwell (sm100) GPUs, resolving a NotImplementedError
that prevented cutlass_moe_fp4
usage on Blackwell.
Highlights
- Build System Enhancement: I've updated
CMakeLists.txt
to explicitly define theENABLE_CUTLASS_MOE_SM100
compiler flag when building NVFP4 kernels. This ensures that the necessary flag for Blackwell (sm100) MoE support is present during compilation. - Multi-Architecture Compilation for MoE Data: I've added a new build block in
CMakeLists.txt
specifically formoe_data.cu
. This ensures thatmoe_data.cu
is compiled for bothsm90
(Hopper) andsm100
(Blackwell) architectures, provided the CUDA compiler version is 12.3 or greater. This is crucial for supporting MoE kernels across different GPU generations. - Conditional Compilation Logic Correction: I've corrected a preprocessor directive in
csrc/quantization/cutlass_w8a8/scaled_mm_entry.cu
. The condition for enablingsm100
MoE kernels was incorrectly checking forENABLE_SCALED_MM_SM90
. It now correctly checks forENABLE_CUTLASS_MOE_SM100
, resolving aNotImplementedError
when running on Blackwell.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug where the get_cutlass_moe_mm_data
function was not compiled for the sm100 architecture, causing issues with cutlass_moe_fp4
usage. The changes include adding a compiler flag for sm100, ensuring moe_data.cu is built for relevant architectures, and correcting a conditional compilation check. I've identified a potentially incorrect condition that should be reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks! |
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
Purpose
The fix in #19648 was disruptive for Blackwell's
cutlass_moe_fp4
usage. This is becauseget_cutlass_moe_mm_data
is used for bothrun_cutlass_moe_fp8
(sm90) andcutlass_moe_fp4
(sm100)While trying to run the kernel, we see the following error:
Thanks to @dsikka and @pavanimajety for finding this issue
Test Plan
Run test on B200
Test Result
Before:
After: