-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Core][Bugfix] New way for full cudagraph, add support for FA2 and FlashInfer #20059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fhl2000
wants to merge
13
commits into
vllm-project:main
Choose a base branch
from
fhl2000:full_cudagraph_FA2_FlashInfer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+617
−140
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
92b1733
FA2 and FlashInfer Full cuda graph support
fhl2000 58ce477
fix the arch support in CMakeLists.txt to include 8.9
fhl2000 c2c5fea
Refactors
fhl2000 1606880
refactors
fhl2000 806432a
Merge branch 'main' into full_cudagraph_FA2_FlashInfer
fhl2000 7c5df45
refactor
fhl2000 c7a9424
Add check for separate_attention_routine flag
fhl2000 e8b9296
fix typo error
fhl2000 94d0b79
Merge branch 'main' into full_cudagraph_FA2_FlashInfer
fhl2000 a67c698
refactors and rearchitect cuda graph logic
fhl2000 da110af
Refactors
fhl2000 deaf0fe
Delect one commit
fhl2000 02ca154
Add support for force_no_split_graph
fhl2000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this has to be platform-specific. If it doesn't, let's create it directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I follow the convention in the
class PiecewiseCompileInterpreter
, where the piecewise_backend is resolved as platform-specific. It seemsCUDAPiecewiseBackend
support is limited on the cuda and rocm platforms.