Skip to content

[Misc][ROCm] Enforce no unused variable in ROCm C++ files #19796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

[Misc][ROCm] Enforce no unused variable in ROCm C++ files #19796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmake/utils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ function (get_torch_gpu_compiler_flags OUT_GPU_FLAGS GPU_LANG)
"-DENABLE_FP8"
"-U__HIP_NO_HALF_CONVERSIONS__"
"-U__HIP_NO_HALF_OPERATORS__"
"-Werror=unused-variable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding -Werror=unused-variable is a good step towards improving code quality and maintainability for ROCm builds by ensuring no variables are declared and left unused.

However, introducing a flag that turns warnings into errors can potentially break the build if there are existing instances of unused variables in the ROCm C++ codebase. The pull request description indicates that the Test Plan and Test Results are still 'TODO'.

It's crucial to:

  1. Run a full build for ROCm targets with this flag enabled.
  2. Identify and fix any build errors caused by this new flag. This might involve removing the unused variables or annotating them with [[maybe_unused]] if they are intentionally unused for a valid reason (e.g., future use, conditional compilation).
  3. Update the pull request description with the test plan executed and the results, confirming that the codebase compiles cleanly with this enforcement.

Without this validation, merging this change risks disrupting the development workflow for anyone building for ROCm.

Copy link
Collaborator Author

@houseroad houseroad Jun 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with the local building.

"-fno-gpu-rdc")

endif()
Expand Down