-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Model] GPT2ForSequenceClassification model #19663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nie3e <adrcwiek@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nie3e, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've summarized this pull request which adds support for the GPT2ForSequenceClassification
model. This enables users to run GPT-2 models fine-tuned for sequence classification tasks directly within vLLM, leveraging its optimized inference capabilities.
Highlights
- New Model Class: I see the introduction of
GPT2ForSequenceClassification
, a new class inheriting fromnn.Module
that wraps the baseGPT2Model
and adds classification-specific layers. - Classification Logic: The new class includes a
pooler
method that implements last-token pooling, applies a linear scoring layer, and a Softmax activation to produce classification scores. - Model Registration: The
GPT2ForSequenceClassification
model is registered in the model registry, making it discoverable and loadable by vLLM.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds support for GPT2ForSequenceClassification
. The implementation is clear and aligns well with vLLM's architecture. The pooling mechanism correctly utilizes the last token's representation for classification. One minor improvement is suggested for the nn.Softmax
layer initialization to ensure explicitness and future compatibility.
Adds dim do Softmax Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: nie3e <adrcwiek@gmail.com>
Signed-off-by: nie3e <adrcwiek@gmail.com>
Signed-off-by: nie3e <adrcwiek@gmail.com>
@Isotr0py You are right! Thanks to your help the code looks much simpler! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your patience!
@Isotr0py one thing before I fix tests. I am not sure if this model is correctly put into Edit: |
You can put it in |
Signed-off-by: nie3e <adrcwiek@gmail.com>
Head branch was pushed to by a user without write access
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: nie3e <adrcwiek@gmail.com>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: nie3e <adrcwiek@gmail.com>
Signed-off-by: nie3e <adrcwiek@gmail.com>
@Isotr0py Can we somehow rerun v1-test?
|
#19872 should fix the CI deadlock, you can merge from main to get the fix. |
Signed-off-by: nie3e <adrcwiek@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> added notebooks to playground updates remoted verbatim HF secrets from all files updates [custom_op][vllm-plugin] update custom_op class to use op_registry (vllm-project#19164) Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Export NaNs in logits to scheduler_stats if output is corrupted (vllm-project#18777) Signed-off-by: Vlad Mihailescu <vtmihailescu@gmail.com> [CPU][CI] Fallback sliding window to v0 and fix CPU pooling model tests (vllm-project#19901) Signed-off-by: jiang1.li <jiang1.li@intel.com> [Kernel] mark TorchSDPABackend swap_blocks NotImplementedError (vllm-project#19749)
Can you open another PR to update the Supported Models page? |
Signed-off-by: nie3e <adrcwiek@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: nie3e <adrcwiek@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: juncheoll <th6re8e@naver.com>
Signed-off-by: nie3e <adrcwiek@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: fhl <2410591650@qq.com>
Signed-off-by: nie3e <adrcwiek@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Support
GPT2ForSequenceClassification
model.Tested on
nie3e/sentiment-polish-gpt2-small
Test:
Result: