Skip to content

[Misc] Modularize CLI Argument Parsing in Benchmark Scripts #19593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion benchmarks/benchmark_latency.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def run_to_completion(profile_dir: Optional[str] = None):
save_to_pytorch_benchmark_format(args, results)


if __name__ == "__main__":
def create_argument_parser():
parser = FlexibleArgumentParser(
description="Benchmark the latency of processing a single batch of "
"requests till completion."
Expand Down Expand Up @@ -171,6 +171,12 @@ def run_to_completion(profile_dir: Optional[str] = None):
# V1 enables prefix caching by default which skews the latency
# numbers. We need to disable prefix caching by default.
parser.set_defaults(enable_prefix_caching=False)

return parser


if __name__ == "__main__":
parser = create_argument_parser()
args = parser.parse_args()
if args.profile and not envs.VLLM_TORCH_PROFILER_DIR:
raise OSError(
Expand Down
8 changes: 7 additions & 1 deletion benchmarks/benchmark_long_document_qa_throughput.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def main(args):
)


if __name__ == "__main__":
def create_argument_parser():
parser = FlexibleArgumentParser(
description="Benchmark the performance with or "
"without automatic prefix caching."
Expand Down Expand Up @@ -192,5 +192,11 @@ def main(args):
)

parser = EngineArgs.add_cli_args(parser)

return parser


if __name__ == "__main__":
parser = create_argument_parser()
args = parser.parse_args()
main(args)
8 changes: 7 additions & 1 deletion benchmarks/benchmark_prefix_caching.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def main(args):
)


if __name__ == "__main__":
def create_argument_parser():
parser = FlexibleArgumentParser(
description="Benchmark the performance with or without "
"automatic prefix caching."
Expand Down Expand Up @@ -268,5 +268,11 @@ def main(args):
)

parser = EngineArgs.add_cli_args(parser)

return parser


if __name__ == "__main__":
parser = create_argument_parser()
args = parser.parse_args()
main(args)
8 changes: 7 additions & 1 deletion benchmarks/benchmark_prioritization.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def main(args: argparse.Namespace):
json.dump(results, f, indent=4)


if __name__ == "__main__":
def create_argument_parser():
parser = FlexibleArgumentParser(description="Benchmark the throughput.")
parser.add_argument(
"--backend", type=str, choices=["vllm", "hf", "mii"], default="vllm"
Expand Down Expand Up @@ -204,6 +204,12 @@ def main(args: argparse.Namespace):
)

parser = EngineArgs.add_cli_args(parser)

return parser


if __name__ == "__main__":
parser = create_argument_parser()
args = parser.parse_args()
if args.tokenizer is None:
args.tokenizer = args.model
Expand Down
8 changes: 6 additions & 2 deletions benchmarks/benchmark_serving.py
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ def main(args: argparse.Namespace):
save_to_pytorch_benchmark_format(args, result_json, file_name)


if __name__ == "__main__":
def create_argument_parser():
parser = FlexibleArgumentParser(
description="Benchmark the online serving throughput."
)
Expand Down Expand Up @@ -1225,6 +1225,10 @@ def main(args: argparse.Namespace):
"script chooses a LoRA module at random.",
)

args = parser.parse_args()
return parser


if __name__ == "__main__":
parser = create_argument_parser()
args = parser.parse_args()
main(args)
7 changes: 6 additions & 1 deletion benchmarks/benchmark_serving_structured_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ def main(args: argparse.Namespace):
json.dump(results, outfile, indent=4)


if __name__ == "__main__":
def create_argument_parser():
parser = FlexibleArgumentParser(
description="Benchmark the online serving throughput."
)
Expand Down Expand Up @@ -1034,5 +1034,10 @@ def main(args: argparse.Namespace):
help="Ratio of Structured Outputs requests",
)

return parser


if __name__ == "__main__":
parser = create_argument_parser()
args = parser.parse_args()
main(args)
8 changes: 7 additions & 1 deletion benchmarks/benchmark_throughput.py
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ def validate_args(args):
)


if __name__ == "__main__":
def create_argument_parser():
parser = FlexibleArgumentParser(description="Benchmark the throughput.")
parser.add_argument(
"--backend",
Expand Down Expand Up @@ -717,6 +717,12 @@ def validate_args(args):
)

parser = AsyncEngineArgs.add_cli_args(parser)

return parser


if __name__ == "__main__":
parser = create_argument_parser()
args = parser.parse_args()
if args.tokenizer is None:
args.tokenizer = args.model
Expand Down