Skip to content

[Model] Fix minimax model cache & lm_head precision #19592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

[Model] Fix minimax model cache & lm_head precision #19592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be7fb15
fix fp
qscqesze Jun 13, 2025
05306eb
fix lm_head float
qscqesze Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vllm/model_executor/models/minimax_text_01.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ def layer_fn(prefix):
self._dtype = _dummy.dtype
del _dummy

self.minimax_cache = MinimaxCacheManager(dtype=self._dtype,
self.minimax_cache = MinimaxCacheManager(dtype=torch.float32,
cache_shape=self.cache_shape)

rope_theta = getattr(config, "rope_theta", 10000)
Expand Down Expand Up @@ -1021,7 +1021,7 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = "") -> None:

else:
self.lm_head = PPMissingLayer()

self.lm_head.float()
flash_layer_count = sum(1 for attn_type in self.config.attn_type_list
if attn_type == 1)
self.kv_cache = [torch.tensor([]) for _ in range(flash_layer_count)]
Expand Down Expand Up @@ -1054,7 +1054,7 @@ def forward(self,

def compute_logits(self, hidden_states: torch.Tensor,
sampling_metadata: SamplingMetadata) -> torch.Tensor:
logits = self.logits_processor(self.lm_head, hidden_states,
logits = self.logits_processor(self.lm_head, hidden_states.float(),
sampling_metadata)

return logits
Expand Down