Skip to content

Updated mistral_common for latest mistral support #19496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ItzAmirreza
Copy link

Mistral common update to 1.6.0. Fixes issue #19495

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ItzAmirreza, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the project's dependencies by bumping the required version of mistral_common to 1.6.0. This update is intended to provide support for the latest Mistral features and address issue #19495, as mentioned in the PR description.

Highlights

  • Dependency Update: Updated the mistral_common[opencv] dependency requirement from >= 1.5.4 to >= 1.6.0 in both requirements/common.txt and requirements/test.in.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mistral_common dependency to version 1.6.0 in both the common and test requirements files. This update is intended to fix issue #19495, improving compatibility and potentially addressing specific problems related to the previous version. The changes are minimal and focused solely on the dependency version bump.

@mergify mergify bot added the ci/build label Jun 11, 2025
@gaby
Copy link

gaby commented Jun 12, 2025

@ItzAmirreza Can you fix the commit not signed

@ItzAmirreza ItzAmirreza force-pushed the mistral-common-1.6.0-update branch 2 times, most recently from 467e32e to 345db6d Compare June 12, 2025 06:58
Signed-off-by: ItzAmirreza <deadlightbusiness@gmail.com>
@ItzAmirreza ItzAmirreza force-pushed the mistral-common-1.6.0-update branch from 345db6d to 1bdf533 Compare June 12, 2025 07:22
@ItzAmirreza
Copy link
Author

Done, not sure why pre-commit fails tho.

Copy link

mergify bot commented Jun 13, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ItzAmirreza.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jun 13, 2025
@gaby
Copy link

gaby commented Jun 13, 2025

@ItzAmirreza Feel free to close this. The dependency was updated already here #19533

@ItzAmirreza ItzAmirreza deleted the mistral-common-1.6.0-update branch June 13, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants