-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[mistral_common] Add v11 tokenizer #19193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
njhill
merged 9 commits into
vllm-project:main
from
patrickvonplaten:add_v11_mistral_common
Jun 5, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c16103f
Allow AsyncLLMEngine.generate to target a specific DP rank (#19102)
jmswen 722fce0
[Bugfix][EP+DP] Fix internode check (#19112)
tlrmchlsmth 83e3c49
WIP
patrickvonplaten 30a164d
WIP
patrickvonplaten f730c05
Update vllm/entrypoints/openai/tool_parsers/mistral_tool_parser.py
patrickvonplaten 4cd7b18
Update vllm/transformers_utils/tokenizers/mistral.py
patrickvonplaten ea650b3
Trigger CI build
patrickvonplaten 2941b28
clean
patrickvonplaten cfb0094
Merge branch 'main' of https://github.com/patrickvonplaten/vllm into …
patrickvonplaten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed that this regex sadly doesn't match the outer most {...} but instead only the inner-most. This means that for inputs such as:
'{"sub_dict": {....}}' it incorrectly parse it to '{"sub_dict": {....}' => and hence miss the final
{
. The corrected regex should be:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the find. I can post a fix for this