Skip to content

Conversation

tlrmchlsmth
Copy link
Member

@tlrmchlsmth tlrmchlsmth commented Jun 2, 2025

Force pplx-kernels a2a to use the internode case (instead of intranode), as it fails with the error:

Failed: Cuda error /app/pplx/csrc/all_to_all/intranode.cpp:84 'invalid resource handle'
[vllm-0:809  :1:1116] Caught signal 11 (Segmentation fault: address not mapped to object at address 0x710fac02bb3c)

Also handles an interface difference between the intranode and internode kernels.

Taken from #18864

tlrmchlsmth and others added 6 commits May 30, 2025 01:01
Signed-off-by: Tyler Michael Smith <tysmith@redhat.com>
Signed-off-by: Tyler Michael Smith <tysmith@redhat.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Copy link

github-actions bot commented Jun 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 2, 2025
@DarkLight1337 DarkLight1337 merged commit 8a57872 into main Jun 3, 2025
82 checks passed
@DarkLight1337 DarkLight1337 deleted the pplx_intranode branch June 3, 2025 03:36
tlrmchlsmth added a commit that referenced this pull request Jun 3, 2025
Signed-off-by: Tyler Michael Smith <tysmith@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants