Skip to content

Revert "[Core] Improve Tensor serialisation (#18774)" #18857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

njhill
Copy link
Member

@njhill njhill commented May 28, 2025

This reverts commit d73a945.

The changes broke various multimodal CI tests, e.g. https://buildkite.com/vllm/ci/builds/20971#019717d1-ac58-4aa3-b0b4-0bfa51e03fa2/213-7160.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 28, 2025
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
@njhill njhill marked this pull request as draft May 29, 2025 00:52
@njhill
Copy link
Member Author

njhill commented May 29, 2025

Moved to draft since we'll prefer to merge #18860 if it fixes the issue.

Copy link

mergify bot commented May 29, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @njhill.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 29, 2025
@njhill
Copy link
Member Author

njhill commented May 29, 2025

Resolved by #18860

@njhill njhill closed this May 29, 2025
@njhill njhill deleted the revert-18774 branch May 29, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant