Skip to content

[Bugfix] Disable prefix caching by default for benchmark #18771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[Bugfix] Disable prefix caching by default for benchmark #18771

merged 1 commit into from
May 28, 2025

Conversation

cascade812
Copy link
Contributor

@cascade812 cascade812 commented May 27, 2025 •
edited by github-actions bot
Loading

bugfix - Set to False instead of True

@cascade812
[Bugfix] Disable prefix caching by default for benchmark
7baee8c 
Signed-off-by: cascade812 <cascade812@outlook.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@cascade812 cascade812 mentioned this pull request May 27, 2025
Merged
houseroad
houseroad approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. My bad, I should catch the issue earlier

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label May 27, 2025
@houseroad houseroad merged commit 51e98e4 into vllm-project:main May 28, 2025
73 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@cascade812 @amitm02
[Bugfix] Disable prefix caching by default for benchmark (vllm-projec…
59de47f 
…t#18771)

Signed-off-by: cascade812 <cascade812@outlook.com>
Signed-off-by: amit <amit.man@gmail.com>
@cjackal cjackal mentioned this pull request Jun 5, 2025
Open
1 task
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@cascade812 @minpeter
[Bugfix] Disable prefix caching by default for benchmark (vllm-projec…
fa88537 
…t#18771)

Signed-off-by: cascade812 <cascade812@outlook.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cascade812 @houseroad