Skip to content

Add reorder_batch to TPU V1 #18515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented May 22, 2025

Before:

lm_eval --model vllm --model_args pretrained=Qwen/Qwen3-0.6B,max_model_len=2048 --trust_remote_code --tasks gsm8k --num_fewshot 5 --batch_size auto
Processed prompts: 100%|████████████████████████| 1319/1319 [00:53<00:00, 24.55it/s, est. speed input: 24370.56 toks/s, output: 2778.02 toks/s]
Running generate_until requests: 100%|██████████| 1319/1319 [00:53<00:00, 24.48it/s]
vllm (pretrained=Qwen/Qwen3-0.6B,max_model_len=2048,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.4147|±  |0.0136|
|     |       |strict-match    |     5|exact_match|↑  |0.4170|±  |0.0136|

After:

lm_eval --model vllm --model_args pretrained=Qwen/Qwen3-0.6B,max_model_len=2048 --trust_remote_code --tasks gsm8k --num_fewshot 5 --batch_size auto
Processed prompts: 100%|████████████████████████| 1319/1319 [00:53<00:00, 24.50it/s, est. speed input: 24319.66 toks/s, output: 2772.22 toks/s]
Running generate_until requests: 100%|██████████| 1319/1319 [00:53<00:00, 24.43it/s]
vllm (pretrained=Qwen/Qwen3-0.6B,max_model_len=2048,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.4147|±  |0.0136|
|     |       |strict-match    |     5|exact_match|↑  |0.4170|±  |0.0136|

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label May 22, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added v1 tpu Related to Google TPUs labels May 22, 2025
@yarongmu-google
Copy link
Contributor

@mgoin Our CI is now green - Chengji is on call this week :) Can we move forward now?

@yarongmu-google
Copy link
Contributor

@yaochengji

@mergify mergify bot added the qwen Related to Qwen models label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants