Skip to content

[V1][P/D] Release nixl xfer handles #18204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ptarasiewiczNV
Copy link
Contributor

@ptarasiewiczNV ptarasiewiczNV commented May 15, 2025

nixl_wrapper.release_xfer_handle is fixed in the current NIXL release so it can be called to release the transfer handles after they are done so they are not kept in memory.

Signed-off-by: Piotr Tarasiewicz <ptarasiewicz@nvidia.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Piotr Tarasiewicz <ptarasiewicz@nvidia.com>
Copy link
Contributor

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Without this free the little memory used by the handle is leaking did I get that right?

Copy link
Contributor

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, this implies nixl>=0.2.0 right?

@ptarasiewiczNV
Copy link
Contributor Author

Without this free the little memory used by the handle is leaking did I get that right?
Correct

On second thought, this implies nixl>=0.2.0 right?
Yes, I have tested with 0.2.1, but possible that it's been fixed in 0.1.1 as well, I will check and get back to you

@njhill
Copy link
Member

njhill commented Jun 19, 2025

Thanks @ptarasiewiczNV. Closing since this was included in #18833.

@njhill njhill closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants