-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid multiple redefinition #1817
Conversation
thank you for your contribution! can you check is this the case for all other header files |
@MitchellX Thanks for the PR! As Simon mentioned, it seems there are several header files that do not have the guards. Could you please add the guards to all theses header files? |
@simon-mo @WoosukKwon Sure, I'll do it later. |
@MitchellX Are you still working on this PR? |
@WoosukKwon My apologies for the oversight. I was so overwhelmed the last few weeks, forgetting to modify the head files. Yes, I'm still working on a vllm related project, and I can help address this issue on Saturday. |
@MitchellX I see. Thanks for letting us know. In this case, can I directly modify this PR to accelerate the process? I think we got your point and just needed to add |
@WoosukKwon Sure, do as you wish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for pointing this out!
By including these guards, you ensure that if ops.h is included multiple times in different files, its contents will only be processed once by the compiler, avoiding redefinition errors and saving time