Skip to content

[V1][Metrics] Remove unused code #18158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[V1][Metrics] Remove unused code #18158

merged 1 commit into from
May 15, 2025

Conversation

markmc
Copy link
Member

@markmc markmc commented May 14, 2025 •
edited by github-actions bot
Loading

This framework was added in #10907 but we never ended up using it.

@markmc
[V1][Metrics] Remove unused code
a256409 
This framework was added in vllm-project#10907 but we never ended up
using it.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@markmc markmc added v1 ready ONLY add when PR is ready to merge/full CI is needed labels May 14, 2025
@mergify mergify bot added the ci/build label May 14, 2025
@vllm-bot vllm-bot merged commit 65334ef into vllm-project:main May 15, 2025
96 of 99 checks passed
@markmc markmc mentioned this pull request May 20, 2025
Closed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@markmc
[V1][Metrics] Remove unused code (vllm-project#18158)
651d1ba 
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@markmc @minpeter
[V1][Metrics] Remove unused code (vllm-project#18158)
1804ef2 
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
@tanujtiwari1998 tanujtiwari1998 mentioned this pull request Jul 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmc @WoosukKwon @vllm-bot