Skip to content

fix: typos #18151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

fix: typos #18151

merged 1 commit into from
May 15, 2025

Conversation

omahs
Copy link
Contributor

@omahs omahs commented May 14, 2025

fix: typos

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation v1 tool-calling labels May 14, 2025
@omahs
fix: typos
7d8918a 
Signed-off-by: omahs <73983677+omahs@users.noreply.github.com>
jeejeelee
jeejeelee approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, LGTM

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label May 15, 2025
@vllm-bot vllm-bot merged commit a9944aa into vllm-project:main May 15, 2025
94 of 97 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@omahs
fix: typos (vllm-project#18151)
d8fde9b 
Signed-off-by: omahs <73983677+omahs@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@omahs @minpeter
fix: typos (vllm-project#18151)
54ca222 
Signed-off-by: omahs <73983677+omahs@users.noreply.github.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
@tanujtiwari1998 tanujtiwari1998 mentioned this pull request Jul 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@ywang96 ywang96 ywang96 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed tool-calling v1
Projects
Tool Calling
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omahs @jeejeelee @ywang96 @vllm-bot