Skip to content

Don't default construct ModelConfig when default constructing VllmConfig #17943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

Don't default construct ModelConfig when default constructing VllmConfig #17943

merged 1 commit into from
May 10, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 10, 2025

Solves issue from #17562 (comment)

@hmellor
Don't default construct ModelConfig when default constructing `Vllm…
4310b60 
…Config`

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor mentioned this pull request May 10, 2025
Merged
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 10, 2025 10:40
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 10, 2025
@DarkLight1337 DarkLight1337 merged commit 6831189 into vllm-project:main May 10, 2025
88 checks passed
@hmellor hmellor deleted the fix-vllm-config-offline branch May 10, 2025 17:30
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Don't default construct ModelConfig when default constructing `Vllm…
adff90d 
…Config` (vllm-project#17943)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@hmellor @mawong-amd
Don't default construct ModelConfig when default constructing `Vllm…
1147463 
…Config` (vllm-project#17943)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Don't default construct ModelConfig when default constructing `Vllm…
9fc504e 
…Config` (vllm-project#17943)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@hmellor @minpeter
Don't default construct ModelConfig when default constructing `Vllm…
f5f39c7 
…Config` (vllm-project#17943)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
@tanujtiwari1998 tanujtiwari1998 mentioned this pull request Jul 8, 2025
Merged
4 tasks
njhill added a commit to njhill/vllm that referenced this pull request Jul 9, 2025
@njhill
[BugFix] Fix VllmConfig() construction on all platforms
ef145c1 
Related to vllm-project#17943. Platform implementations of check_and_update_config() need to tolerate vllm_config.model_config being None.

Signed-off-by: Nick Hill <nhill@redhat.com>
@njhill njhill mentioned this pull request Jul 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @mgoin @DarkLight1337