-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Automatically bind CPU OMP Threads of a rank to CPU ids of a NUMA node. #17930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
06b7fce
automatically bind OMP Threads of a rank to CPU ids of a NUMA node.
louie-tsai 6b4257f
handle hyperthreading on case
louie-tsai 7d4e965
only use cpu cores in the allowed list
louie-tsai 2044000
address Li, Jiang's feedback
louie-tsai ade9d80
Apply suggestions from code review
louie-tsai 77e13b2
change default to auto
louie-tsai 87d6ecd
Update vllm/worker/cpu_worker.py
louie-tsai bf0416a
Update vllm/worker/cpu_worker.py
louie-tsai fa08ab7
change from issubset to intersect according to Antti's feedback
louie-tsai 755c4b3
pre-commit fix
louie-tsai 938c9cd
get cpus_allow_list in main process
louie-tsai 5eaf831
Update cpu.md
louie-tsai 00a3633
set default value to all to simplify if else statement
louie-tsai 42998fe
pre-commit fix
louie-tsai 01ac794
fix correctness test for gpu
louie-tsai 9b50fc9
fix forked processes of ranks issue for cpus_allow_list by changing t…
louie-tsai 071629c
change to handle non-continuous cpu ids case
louie-tsai fb70dc9
move auto binding into a function
louie-tsai b9089bf
Update cpu.md to address Antti's feedback
louie-tsai 108a407
add auto binding into V1 feature
louie-tsai efaf0b2
address isotr0py's feedback
louie-tsai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we double set this. duplicate to L199. may due to rebase not auto merge this change.