Skip to content

[BugFix] Avoid secondary missing MultiprocExecutor.workers error #17811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

[BugFix] Avoid secondary missing MultiprocExecutor.workers error #17811

merged 1 commit into from
May 7, 2025

Conversation

njhill
Copy link
Member

@njhill njhill commented May 7, 2025 •
edited by github-actions bot
Loading

If V1 MultiprocExecutor fails during startup before the workers field has been set it will result in secondary confusing exception: AttributeError: 'MultiprocExecutor' object has no attribute 'workers'.

As reported in #17756 and #17533.

@njhill
[BugFix] Avoid secondary missing MultiprocExecutor.workers error
7939233 
If V1 MultiprocExecutor fails during startup before the workers field has been set it will result in secondary confusing exceptions: 'MultiprocExecutor' object has no attribute 'workers'

Signed-off-by: Nick Hill <nhill@redhat.com>
@njhill njhill added the bug Something isn't working label May 7, 2025
@njhill njhill requested a review from alexm-redhat as a code owner May 7, 2025 16:39
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 7, 2025
This was referenced May 7, 2025
Closed
Open
houseroad
houseroad approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
@njhill njhill enabled auto-merge (squash) May 7, 2025 18:18
@njhill njhill merged commit ed5272c into vllm-project:main May 7, 2025
68 of 69 checks passed
@abner2015
Copy link

use your method have a new error : workerproc initialization failed due to an exception in a backgroud process

@rainmaple rainmaple mentioned this pull request May 8, 2025
Open
1 task
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@njhill @princepride
[BugFix] Avoid secondary missing MultiprocExecutor.workers error (v…
a49056b 
…llm-project#17811)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
@lk-chen lk-chen mentioned this pull request May 12, 2025
Closed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@njhill
[BugFix] Avoid secondary missing MultiprocExecutor.workers error (v…
a745b65 
…llm-project#17811)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@njhill @mawong-amd
[BugFix] Avoid secondary missing MultiprocExecutor.workers error (v…
202059e 
…llm-project#17811)

Signed-off-by: Nick Hill <nhill@redhat.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@njhill
[BugFix] Avoid secondary missing MultiprocExecutor.workers error (v…
0865281 
…llm-project#17811)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@njhill @minpeter
[BugFix] Avoid secondary missing MultiprocExecutor.workers error (v…
a08a581 
…llm-project#17811)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
@tanujtiwari1998 tanujtiwari1998 mentioned this pull request Jul 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njhill @abner2015 @houseroad