Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set top_p=0 and top_k=-1 in greedy sampling #1748

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Set top_p=0 and top_k=-1 in greedy sampling #1748

merged 1 commit into from
Nov 22, 2023

Conversation

beginlner
Copy link
Contributor

No description provided.

zhuohan123
zhuohan123 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@zhuohan123 zhuohan123 merged commit 4cea74c into vllm-project:main Nov 22, 2023
2 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Dec 4, 2023
@beginlner
Set top_p=0 and top_k=-1 in greedy sampling (vllm-project#1748)
860becd
@beginlner beginlner deleted the patch-3 branch December 19, 2023 01:41
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@beginlner
Set top_p=0 and top_k=-1 in greedy sampling (vllm-project#1748)
b52b540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beginlner @zhuohan123