[Feat] Add deprecated=True to CLI args #17426

aarnphm · 2025-04-30T00:44:19Z

This PR adds a small helper to FlexibleArgumentParser to
mark an argument as deprecated, aligning with python 3.13 and above logic

This PR also marks --enable-reasoning as deprecated.

Signed-off-by: Aaron Pham contact@aarnphm.xyz

github-actions · 2025-04-30T00:44:28Z

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

hmellor

Could it behave something like https://docs.python.org/3/library/argparse.html#deprecated?

aarnphm · 2025-04-30T01:28:17Z

Oh this is added in 3.13. I will take a look for backport on this then

hmellor · 2025-04-30T13:09:16Z

Ideally it would just be a kwarg we can add to add_argument which triggers a generic warning that this arg is deprecated.

Then somewhere inside the code there will most likely be another warning from @deprecated with the details of the deprecation.

aarnphm · 2025-04-30T14:31:55Z

Hmm, then maybe similar implementation as the builtins behaviour of 3.13 would suffice?

hmellor · 2025-04-30T15:12:29Z

Yeah I was thinking we emulate the 3.13 behaviour because it'll seem "normal" to modern Python users but we won't be able to use the builtin functionality for years!

aarnphm · 2025-05-02T21:20:11Z

@hmellor should be ready for another round of review

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

vllm/engine/arg_utils.py

vllm/utils.py

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

hmellor

Looks good overall, but you've used some syntax that isn't compatible with Python 3.9

vllm/utils.py

hmellor

LGTM, thanks for bringing us this feature from the future!

* [Model] Add GraniteMoeHybrid 4.0 model (vllm-project#17497) Signed-off-by: Thomas Ortner <boh@zurich.ibm.com> Signed-off-by: Stanislaw Wozniak <stw@zurich.ibm.com> Co-authored-by: Thomas Ortner <boh@zurich.ibm.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Tyler Michael Smith <tysmith@redhat.com> * [easy] Fix logspam on PiecewiseBackend errors (vllm-project#17138) Signed-off-by: rzou <zou3519@gmail.com> * [Bugfix] Fixed prompt length for random dataset (vllm-project#17408) Signed-off-by: Mikhail Podvitskii <podvitskiymichael@gmail.com> * [Doc] Update notes for H2O-VL and Gemma3 (vllm-project#17219) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> * [Misc] Fix ScalarType float4 naming (vllm-project#17690) Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com> * Fix `dockerfilegraph` pre-commit hook (vllm-project#17698) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * [Bugfix] Fix triton import with local TritonPlaceholder (vllm-project#17446) Signed-off-by: Mengqing Cao <cmq0113@163.com> * [V1] Enable TPU V1 backend by default (vllm-project#17673) Signed-off-by: mgoin <mgoin64@gmail.com> * [V1][PP] Support PP for MultiprocExecutor (vllm-project#14219) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: jiang.li <jiang1.li@intel.com> * [v1] AttentionMetadata for each layer (vllm-project#17394) Signed-off-by: Chen Zhang <zhangch99@outlook.com> * [Feat] Add deprecated=True to CLI args (vllm-project#17426) Signed-off-by: Aaron Pham <contact@aarnphm.xyz> * [Docs] Use gh-file to add links to tool_calling.md (vllm-project#17709) Signed-off-by: windsonsea <haifeng.yao@daocloud.io> * [v1] Introduce KVCacheBlocks as interface between Scheduler and KVCacheManager (vllm-project#17479) Signed-off-by: Chen Zhang <zhangch99@outlook.com> * [doc] Add RAG Integration example (vllm-project#17692) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> * [Bugfix] Fix modality limits in vision language example (vllm-project#17721) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> * Make right sidebar more readable in "Supported Models" (vllm-project#17723) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * [TPU] Increase block size and reset block shapes (vllm-project#16458) * [Misc] Add Next Edit Prediction (NEP) datasets support in `benchmark_serving.py` (vllm-project#16839) Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal> Signed-off-by: dtransposed <> Co-authored-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal> * [Bugfix] Fix for the condition to accept empty encoder inputs for mllama (vllm-project#17732) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> * [Kernel] Unified Triton kernel that doesn't distinguish between prefill + decode (vllm-project#16828) Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com> Co-authored-by: Lucas Wilkinson <lwilkinson@neuralmagic.com> --------- Signed-off-by: Thomas Ortner <boh@zurich.ibm.com> Signed-off-by: Stanislaw Wozniak <stw@zurich.ibm.com> Signed-off-by: rzou <zou3519@gmail.com> Signed-off-by: Mikhail Podvitskii <podvitskiymichael@gmail.com> Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Mengqing Cao <cmq0113@163.com> Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: jiang.li <jiang1.li@intel.com> Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Signed-off-by: windsonsea <haifeng.yao@daocloud.io> Signed-off-by: reidliu41 <reid201711@gmail.com> Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal> Signed-off-by: dtransposed <> Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: rshaw@neuralmagic.com <robertgshaw2@gmail.com> Co-authored-by: Stan Wozniak <77159600+s3woz@users.noreply.github.com> Co-authored-by: Thomas Ortner <boh@zurich.ibm.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Tyler Michael Smith <tysmith@redhat.com> Co-authored-by: Richard Zou <zou3519@users.noreply.github.com> Co-authored-by: Mikhail Podvitskii <podvitskiymichael@gmail.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Mengqing Cao <cmq0113@163.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com> Co-authored-by: Chen Zhang <zhangch99@outlook.com> Co-authored-by: Aaron Pham <contact@aarnphm.xyz> Co-authored-by: Michael Yao <haifeng.yao@daocloud.io> Co-authored-by: Reid <61492567+reidliu41@users.noreply.github.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Co-authored-by: Jevin Jiang <jevin0change@gmail.com> Co-authored-by: d.transposed <damian.bogunowicz@gmail.com> Co-authored-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal> Co-authored-by: Gregory Shtrasberg <156009573+gshtras@users.noreply.github.com> Co-authored-by: Thomas Parnell <tpa@zurich.ibm.com> Co-authored-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>

Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>

Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Signed-off-by: minpeter <kali2005611@gmail.com>

aarnphm requested review from hmellor and DarkLight1337 April 30, 2025 00:44

hmellor reviewed Apr 30, 2025

View reviewed changes

chaunceyjiang mentioned this pull request Apr 30, 2025

[Feature][Frontend]: Deprecate --enable-reasoning #17452

Merged

aarnphm requested a review from hmellor May 2, 2025 21:20

aarnphm added 2 commits May 2, 2025 17:23

feat: add deprecated=True and deprecate_reason for argparse

861a68e

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

chore: match upstream 3.13

38b8d55

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

aarnphm force-pushed the feat/deprecated-argument branch from 11f0f9e to 38b8d55 Compare May 2, 2025 21:23

fix: works with subgroup

2439473

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

aarnphm force-pushed the feat/deprecated-argument branch from 06e5ce8 to 2439473 Compare May 2, 2025 21:36

--wip--

fa47e7b

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

hmellor reviewed May 2, 2025

View reviewed changes

aarnphm added 2 commits May 2, 2025 22:30

chore: update backport

d49e4ee

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

chore: cleanup deprecated for '--enable-reasoning' instead

6260b24

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

aarnphm requested a review from hmellor May 4, 2025 00:52

chore: cleanup format and waren signs

60ce9b8

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

hmellor reviewed May 5, 2025

View reviewed changes

vllm/utils.py Show resolved Hide resolved

aarnphm requested a review from hmellor May 5, 2025 18:13

aarnphm added this to the v0.9.0 milestone May 5, 2025

hmellor approved these changes May 5, 2025

View reviewed changes

hmellor enabled auto-merge (squash) May 5, 2025 18:41

github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 5, 2025

hmellor mentioned this pull request May 6, 2025

[Misc] Remove qlora_adapter_name_or_path #17699

Merged

vllm-bot merged commit 175bda6 into vllm-project:main May 6, 2025
70 of 74 checks passed

aarnphm deleted the feat/deprecated-argument branch May 6, 2025 23:28

sarckk mentioned this pull request May 7, 2025

Make key optional for rotary embedding #17566

Merged

RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025

[Feat] Add deprecated=True to CLI args (vllm-project#17426)

f7e6605

Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>

mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025

[Feat] Add deprecated=True to CLI args (vllm-project#17426)

a77169d

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025

[Feat] Add deprecated=True to CLI args (vllm-project#17426)

c84c2c7

Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>

This was referenced Jun 3, 2025

refactor vllm cli arg parser to FlexibleArgumentParser NVIDIA/RULER#91

Merged

[Feature]: Warn or auto-convert to FlexibleArgumentParser in AsyncEngineArgs.add_cli_args #19221

Open

minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025

[Feat] Add deprecated=True to CLI args (vllm-project#17426)

4b6e295

Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Signed-off-by: minpeter <kali2005611@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Feat] Add deprecated=True to CLI args #17426

[Feat] Add deprecated=True to CLI args #17426

Uh oh!

aarnphm commented Apr 30, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

hmellor left a comment

Uh oh!

aarnphm commented Apr 30, 2025

Uh oh!

hmellor commented Apr 30, 2025

Uh oh!

aarnphm commented Apr 30, 2025

Uh oh!

hmellor commented Apr 30, 2025

Uh oh!

aarnphm commented May 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hmellor left a comment

Uh oh!

Uh oh!

hmellor left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[Feat] Add deprecated=True to CLI args #17426

[Feat] Add deprecated=True to CLI args #17426

Uh oh!

Conversation

aarnphm commented Apr 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

hmellor left a comment

Choose a reason for hiding this comment

Uh oh!

aarnphm commented Apr 30, 2025

Uh oh!

hmellor commented Apr 30, 2025

Uh oh!

aarnphm commented Apr 30, 2025

Uh oh!

hmellor commented Apr 30, 2025

Uh oh!

aarnphm commented May 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hmellor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hmellor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aarnphm commented Apr 30, 2025 •

edited by github-actions bot

Loading