Skip to content

[TPU][V1][CI] Replace python3 setup.py develop with standard pip install --e on TPU #17374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025
Merged

[TPU][V1][CI] Replace python3 setup.py develop with standard pip install --e on TPU #17374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f34ee6
debug
NickLucche Apr 29, 2025
52b6d4f
debug
NickLucche Apr 29, 2025
3e94afb
debug
NickLucche Apr 29, 2025
fb81c28
debug
NickLucche Apr 29, 2025
1a6eb80
revert setuptools
NickLucche Apr 29, 2025
3775e27
setup develop is deprecated
NickLucche Apr 29, 2025
69f5547
pip install -e docs
NickLucche Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile.tpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ RUN --mount=type=cache,target=/root/.cache/pip \
--mount=type=bind,source=.git,target=.git \
python3 -m pip install \
-r requirements/tpu.txt
RUN python3 setup.py develop
RUN python3 -m pip install -e .

# install development dependencies (for testing)
RUN python3 -m pip install -e tests/vllm_test_utils
Expand Down
2 changes: 1 addition & 1 deletion docs/source/getting_started/installation/ai_accelerator/tpu.inc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ sudo apt-get install libopenblas-base libopenmpi-dev libomp-dev
Run the setup script:

```bash
VLLM_TARGET_DEVICE="tpu" python setup.py develop
VLLM_TARGET_DEVICE="tpu" python -m pip install -e .
```

## Set up using Docker
Expand Down