-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate linter from pylint
to ruff
#1665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, Simon! LGTM in general. I have some dumb questions:
- Does this new style linter strictly follow google python style guide? If not, which standard does it follow?
- Does this linter forces line width at all? If so, what's the line width it forced?
pyproject.toml
Outdated
"E731", | ||
# line too long, handled by black formatting | ||
"E501", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: new line
No I explicitly turned it down by ignoring error |
The ruleset is roughly the same.
ruff
actually implement at lot more other rules that's super useful.ruff
yields 300x speedup for linting the files.Currently I have disabled import sorting rules as the changes are going to be more drastic.
Additionally,
ruff
can automatically fixes the linting issue, saving developer time: https://docs.astral.sh/ruff/linter/#fixes