Skip to content

[Hardware][TPU] Add torchvision to tpu dependency file #16616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

lsy323
Copy link
Collaborator

@lsy323 lsy323 commented Apr 14, 2025

Switch to official torch nightly whl for TPU, this is needed for including torchvision in the TPU dependency list. torchvision has a hard dependency on the torch nightly whl on the same date, and --no-dep cannot be added to the requirement file.

However, there is a small possibility that the official torch nightly whl to be not compatible with the torch_xla nightly whl on the same date (The commit which the official torch whl is built can be different from the torch commit torch_xla is built on, therefore the conflict may happen)

Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@lsy323 lsy323 requested a review from mgoin April 14, 2025 20:14
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 14, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! This worked locally for me

@mgoin mgoin added tpu Related to Google TPUs ready ONLY add when PR is ready to merge/full CI is needed labels Apr 14, 2025
@mergify mergify bot removed the tpu Related to Google TPUs label Apr 14, 2025
@mgoin mgoin merged commit c64ee87 into vllm-project:main Apr 14, 2025
40 of 42 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…16616)

Signed-off-by: Siyuan Liu <lsiyuan@google.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…16616)

Signed-off-by: Siyuan Liu <lsiyuan@google.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants