-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[VLM] Remove BaseProcessingInfo.get_mm_max_tokens_per_item
#16408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VLM] Remove BaseProcessingInfo.get_mm_max_tokens_per_item
#16408
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…oject#16408) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Yang Wang <elainewy@meta.com>
…oject#16408) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…oject#16408) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…oject#16408) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
It is somewhat redundant to use
BaseProcessingInfo.get_mm_max_tokens_per_item
when we can directly get the number of multi-modal tokens from the dummy data now (viaPlaceholderRange.get_num_embeds
added by #15712).Although this means we need to generate the dummy data to get the multi-modal token count, this is only called once before profiling starts, so it shouldn't affect the performance much. On the other hand, this simplifies the code somewhat by removing one abstract method. Note however that we still need to compute the number of multimodal tokens for the prompt updates.
This change won't conflict with the current WIP models since it just makes the abstract method unused rather than banning it.