Skip to content

[VLM] Remove BaseProcessingInfo.get_mm_max_tokens_per_item #16408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 10, 2025

It is somewhat redundant to use BaseProcessingInfo.get_mm_max_tokens_per_item when we can directly get the number of multi-modal tokens from the dummy data now (via PlaceholderRange.get_num_embeds added by #15712).

Although this means we need to generate the dummy data to get the multi-modal token count, this is only called once before profiling starts, so it shouldn't affect the performance much. On the other hand, this simplifies the code somewhat by removing one abstract method. Note however that we still need to compute the number of multimodal tokens for the prompt updates.

This change won't conflict with the current WIP models since it just makes the abstract method unused rather than banning it.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from Isotr0py April 10, 2025 13:28
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner April 10, 2025 13:28
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) labels Apr 10, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@vllm-bot vllm-bot merged commit 83b824c into vllm-project:main Apr 10, 2025
30 of 32 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Multi-modality Core Apr 10, 2025
@DarkLight1337 DarkLight1337 deleted the no-mm-max-tokens-per-item branch April 10, 2025 16:08
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…oject#16408)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
…oject#16408)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
…oject#16408)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…oject#16408)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants