Skip to content

[Bugfix]fix asyncLLM test_abort #16090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix]fix asyncLLM test_abort #16090

wants to merge 1 commit into from

Conversation

KubeKyrie
Copy link

@KubeKyrie KubeKyrie commented Apr 5, 2025 •
edited by github-actions bot
Loading

FIX #16054

Need async wait for aborting the request actually.

@KubeKyrie
fix asyncLLM test_abort
a07dcce 
Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 5, 2025
@KubeKyrie
Copy link
Author

@DarkLight1337 Hi, could u help review this pr, thanks.

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jun 13, 2025 •
edited
Loading

I think this isn't a good fix. It suggests that we have some timing-based issue that needs to be resolved

@DarkLight1337 DarkLight1337 requested a review from njhill June 13, 2025 03:22
njhill
njhill reviewed Jun 17, 2025
View reviewed changes
tests/v1/engine/test_async_llm.py
@@ -175,6 +175,7 @@ async def test_abort(monkeypatch: pytest.MonkeyPatch,
f"expected {expected_tokens}")

# Make sure all aborted requests were really aborted.
await asyncio.sleep(0.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KubeKyrie could you explain why this is needed? We already yield after each of the cancel() calls above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhill njhill njhill left review comments

@lgeiger lgeiger lgeiger approved these changes

Assignees
No one assigned
Labels
v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: CI flake - v1/engine/test_async_llm.py::test_abort - assert has_unfinished_requests()
4 participants
@KubeKyrie @DarkLight1337 @lgeiger @njhill