Skip to content

[bugfix] add seed in torchrun_example.py #15980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Apr 3, 2025

fixes #15895

#14274 updated the tests/distributed/test_torchrun_example.py , but didn't update torchrun_example.py .

Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link

github-actions bot commented Apr 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@youkaichao youkaichao requested a review from WoosukKwon April 3, 2025 02:47
@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 3, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we also raise an error when the external_launcher is used without a seed?

Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
Copy link
Member Author

Can we also raise an error when the external_launcher is used without a seed?

done in 9369ba5

@youkaichao youkaichao merged commit 8b66470 into vllm-project:main Apr 3, 2025
7 of 12 checks passed
@youkaichao youkaichao deleted the seed_example branch April 3, 2025 04:25
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TP with external_launcher is not working with vLLM version 0.8.0 and above
2 participants