Skip to content

[CI] xgrammar structured output supports Enum. #15757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2025
Merged

[CI] xgrammar structured output supports Enum. #15757

merged 2 commits into from
Mar 30, 2025

Conversation

chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Mar 30, 2025 •
edited by github-actions bot
Loading

xgrammar structured output supports Enum.

Fix: https://buildkite.com/vllm/ci/builds/16518#0195de7e-5b32-42e7-b741-8747cb4985db

Failure it was caused by #15594

@chaunceyjiang
[Misc] xgrammar structured output supports Enum.
bb885d3 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 30, 2025
@chaunceyjiang
[Misc] xgrammar structured output supports Enum.
a1087e0 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Contributor Author

test

pytest tests/v1/structured_output/test_utils.py -s -v
image

@chaunceyjiang
Copy link
Contributor Author

/cc @russellb @DarkLight1337 PTAL.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 30, 2025 02:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 30, 2025
@vllm-bot vllm-bot merged commit 0455337 into vllm-project:main Mar 30, 2025
20 of 24 checks passed
@markmc markmc mentioned this pull request Mar 31, 2025
Merged
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
@chaunceyjiang @kylesayrs
[CI] xgrammar structured output supports Enum. (vllm-project#15757)
a2ae3bd 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@chaunceyjiang @Alex4210987
[CI] xgrammar structured output supports Enum. (vllm-project#15757)
cb75eca 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@chaunceyjiang @lulmer
[CI] xgrammar structured output supports Enum. (vllm-project#15757)
2d849fc 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@chaunceyjiang @nishith-fujitsu
[CI] xgrammar structured output supports Enum. (vllm-project#15757)
8f1977a 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@chaunceyjiang @lk-chen
[CI] xgrammar structured output supports Enum. (vllm-project#15757)
8461ea3 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@chaunceyjiang @shreyankg
[CI] xgrammar structured output supports Enum. (vllm-project#15757)
4a24f52 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@chaunceyjiang
[CI] xgrammar structured output supports Enum. (vllm-project#15757)
12fc4c7 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@russellb russellb Awaiting requested review from russellb russellb is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaunceyjiang @DarkLight1337 @vllm-bot