Skip to content

[V1] Update structured output offline inference example #15721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

russellb
Copy link
Member

Update this example to work with V1. The grammar specified was not
comaptible with xgrammar. This worked with V0 as we would automatically
fall back to outlines.

In V1 we have fallback support, but you have to opt-in to it by setting
your backend to auto. Grammar type support varies among the backends.

Signed-off-by: Russell Bryant rbryant@redhat.com

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 28, 2025
@russellb russellb requested a review from Copilot March 28, 2025 20:32
Copilot

This comment was marked as resolved.

@russellb
Copy link
Member Author

russellb commented Apr 7, 2025

This change would make the current example work: #15724

but this seems worth landing now to make sure we have something that works, including for recent releases that use V1

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you add r to the start of the regex to remove the warning SyntaxWarning: invalid escape sequence '\w' guided_decoding_params = GuidedDecodingParams(regex="\w+@\w+\.com\n")?

Update this example to work with V1. The grammar specified was not
comaptible with xgrammar. This worked with V0 as we would automatically
fall back to outlines.

In V1 we have fallback support, but you have to opt-in to it by setting
your backend to `auto`. Grammar type support varies among the backends.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb russellb force-pushed the structured-output-example-update-for-v1 branch from 5f3c660 to 71ffe0a Compare April 8, 2025 18:55
@russellb
Copy link
Member Author

russellb commented Apr 8, 2025

LGTM.

Could you add r to the start of the regex to remove the warning SyntaxWarning: invalid escape sequence '\w' guided_decoding_params = GuidedDecodingParams(regex="\w+@\w+\.com\n")?

done!

@russellb russellb requested a review from hmellor April 8, 2025 19:12
@hmellor hmellor enabled auto-merge (squash) April 8, 2025 21:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 8, 2025
@hmellor hmellor merged commit 2755c34 into vllm-project:main Apr 8, 2025
39 of 41 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…#15721)

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…#15721)

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants