-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[V1] Update structured output offline inference example #15721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1] Update structured output offline inference example #15721
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This change would make the current example work: #15724 but this seems worth landing now to make sure we have something that works, including for recent releases that use V1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Could you add r
to the start of the regex to remove the warning SyntaxWarning: invalid escape sequence '\w' guided_decoding_params = GuidedDecodingParams(regex="\w+@\w+\.com\n")
?
Update this example to work with V1. The grammar specified was not comaptible with xgrammar. This worked with V0 as we would automatically fall back to outlines. In V1 we have fallback support, but you have to opt-in to it by setting your backend to `auto`. Grammar type support varies among the backends. Signed-off-by: Russell Bryant <rbryant@redhat.com>
5f3c660
to
71ffe0a
Compare
done! |
…#15721) Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Yang Wang <elainewy@meta.com>
…#15721) Signed-off-by: Russell Bryant <rbryant@redhat.com>
…#15721) Signed-off-by: Russell Bryant <rbryant@redhat.com>
…#15721) Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Update this example to work with V1. The grammar specified was not
comaptible with xgrammar. This worked with V0 as we would automatically
fall back to outlines.
In V1 we have fallback support, but you have to opt-in to it by setting
your backend to
auto
. Grammar type support varies among the backends.Signed-off-by: Russell Bryant rbryant@redhat.com