Skip to content

[Bugfix] Fix mm_hashes forgetting to be passed #15668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Isotr0py merged 1 commit into from
Mar 28, 2025
Merged

[Bugfix] Fix mm_hashes forgetting to be passed #15668

Isotr0py merged 1 commit into from
Mar 28, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 28, 2025 •
edited by github-actions bot
Loading

Make mm_hashes a required key in MultiModalInputs so we don't forget to pass mm_hashes

Also fix Phi-4-multimodal using the wrong class in legacy input processor.

@DarkLight1337
[Bugfix] Fix mm_hashes forgetting to be passed
077e8e0 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 28, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py March 28, 2025 03:05
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner March 28, 2025 03:05
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Mar 28, 2025
@Isotr0py Isotr0py enabled auto-merge (squash) March 28, 2025 03:42
@Isotr0py Isotr0py merged commit 8693e47 into vllm-project:main Mar 28, 2025
39 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-mm-hashes branch March 28, 2025 05:52
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@DarkLight1337 @Alex4210987
[Bugfix] Fix mm_hashes forgetting to be passed (vllm-project#15668)
eef0a22 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Bugfix] Fix mm_hashes forgetting to be passed (vllm-project#15668)
164af0f 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Fix mm_hashes forgetting to be passed (vllm-project#15668)
ab4fc51 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Bugfix] Fix mm_hashes forgetting to be passed (vllm-project#15668)
0a8b134 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Fix mm_hashes forgetting to be passed (vllm-project#15668)
1cdb7aa 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees

No one assigned

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarkLight1337 @Isotr0py