Skip to content

Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnakess/ppa (#13569)" #15377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 24, 2025
Merged

Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnakess/ppa (#13569)" #15377

merged 6 commits into from
Mar 24, 2025

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Mar 24, 2025 •
edited by github-actions bot
Loading

This reverts commit d929278.

Closes #15174
Closes #15088
Closes #15359
Closes #14991

@simon-mo
Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnake…
968d313 
…s/ppa (vllm-project#13569)"

This reverts commit d929278.

Signed-off-by: simon-mo <simon.mo@hey.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 24, 2025
@mergify Mergify
Copy link

mergify bot commented Mar 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @simon-mo.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 24, 2025
simon-mo added 2 commits March 23, 2025 22:52
@simon-mo
typo
aee3e1e 
Signed-off-by: simon-mo <simon.mo@hey.com>
@simon-mo
Merge branch 'main' into revert-13569
e98e0df
@mergify mergify bot removed the needs-rebase label Mar 24, 2025
@simon-mo simon-mo added this to the v0.8.2 milestone Mar 24, 2025
@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 24, 2025
simon-mo added 2 commits March 23, 2025 23:02
@simon-mo
typo
496d640 
Signed-off-by: simon-mo <simon.mo@hey.com>
@simon-mo
Merge branch 'revert-13569' of github.com:simon-mo/vllm into revert-1…
7dce5e6 
…3569
ywang96
ywang96 approved these changes Mar 24, 2025
View reviewed changes
@simon-mo
comment
5d73c1a 
Signed-off-by: simon-mo <simon.mo@hey.com>
hmellor
hmellor approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vllm-bot vllm-bot merged commit 7ffcccf into vllm-project:main Mar 24, 2025
57 of 59 checks passed
@dimalo
Copy link

dimalo commented Mar 24, 2025 •
edited
Loading

Hi, I proposed #15302 a couple of days ago, which fixes the python installation while using uv, maybe a chance for a comeback of #13569? 😄

@Searcherr
Copy link

This reverts commit d929278.

Closes #15174 Closes #15088 Closes #15359 Closes #14991

Thanks a bunch for quick fix! Much appreciate that!

erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@simon-mo @erictang000
Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnake…
dc76b93 
…ss/ppa (vllm-project#13569)" (vllm-project#15377)

Signed-off-by: simon-mo <simon.mo@hey.com>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@simon-mo @wrmedford
Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnake…
95c6c8b 
…ss/ppa (vllm-project#13569)" (vllm-project#15377)

Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@simon-mo @lulmer
Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnake…
f82fc5f 
…ss/ppa (vllm-project#13569)" (vllm-project#15377)

Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@simon-mo @lk-chen
Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnake…
4950963 
…ss/ppa (vllm-project#13569)" (vllm-project#15377)

Signed-off-by: simon-mo <simon.mo@hey.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@simon-mo @shreyankg
Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnake…
0619124 
…ss/ppa (vllm-project#13569)" (vllm-project#15377)

Signed-off-by: simon-mo <simon.mo@hey.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@simon-mo
Revert "[CI/Build] Use uv python for docker rather than ppa:deadsnake…
36f7447 
…ss/ppa (vllm-project#13569)" (vllm-project#15377)

Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor hmellor approved these changes

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
v0.8.2
6 participants
@simon-mo @dimalo @Searcherr @hmellor @ywang96 @vllm-bot