-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[V0][Bugfix] Fix Mamba cache crashing #15296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin Chislett <chislett.ben@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
@tlrmchlsmth is the expert on mamba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It looks like the fix is already in async_llm_engine.py
but not llm_engine.py
, so please merge in latest main. (And please make sure the code is equivalent in the two files as well). Thank you!
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Benjamin Chislett <chislett.ben@gmail.com>
@tlrmchlsmth conflict resolved, diff looks good, ready to merge. |
Is this change not going to be merged? Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benchislett could you merge in latest main?
When a request is finished but the scheduler has no more requests, the
finished_req_ids
will be cleared from the scheduler but the model execution will be skipped. This means that the Mamba cache cannot free the slots for those requests, leading to a slow buildup of unavailable slots until there are none left.This PR changes the behaviour of the LLM engine to only clear the finished_req_ids when there are scheduled requests to process.
FIX #13129