Skip to content

[Misc] Add attention mask pre-computation optimization back to Qwen2.5-VL #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

[Misc] Add attention mask pre-computation optimization back to Qwen2.5-VL #15273

merged 1 commit into from
Mar 21, 2025
+35 −16

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Mar 21, 2025 •
edited by github-actions bot
Loading

@Isotr0py
reduce cuMemcpy operations
88215d5 
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py requested a review from ywang96 March 21, 2025 06:51
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

ywang96
ywang96 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 21, 2025
@ywang96 ywang96 enabled auto-merge (squash) March 21, 2025 08:48
@ywang96 ywang96 merged commit 47c7126 into vllm-project:main Mar 21, 2025
45 checks passed
@Isotr0py Isotr0py deleted the optimize-qwen2_5_vl branch March 21, 2025 15:46
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@Isotr0py @erictang000
[Misc] Add attention mask pre-computation optimization back to Qwen2.…
0adfb5b 
…5-VL (vllm-project#15273)

Signed-off-by: Isotr0py <2037008807@qq.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Isotr0py @lulmer
[Misc] Add attention mask pre-computation optimization back to Qwen2.…
ccbfdcb 
…5-VL (vllm-project#15273)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Isotr0py @shreyankg
[Misc] Add attention mask pre-computation optimization back to Qwen2.…
082ac0a 
…5-VL (vllm-project#15273)

Signed-off-by: Isotr0py <2037008807@qq.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[Misc] Add attention mask pre-computation optimization back to Qwen2.…
173ec70 
…5-VL (vllm-project#15273)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isotr0py @ywang96