Skip to content

[Fix] [torch.compile] Improve UUID system for custom passes #15249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2025
Merged

[Fix] [torch.compile] Improve UUID system for custom passes #15249

merged 5 commits into from
Mar 24, 2025

Conversation

ProExpertProg
Copy link
Collaborator

@ProExpertProg ProExpertProg commented Mar 20, 2025 •
edited by github-actions bot
Loading

Removed pickling for UUID used for caching in 2.6 and maintained backwards compatibility with pickling in 2.5.

FIX #15223
Addresses cruft from #12393

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ProExpertProg
Copy link
Collaborator Author

cc @youkaichao @bnellnm @SageMoore

@ProExpertProg
Removed pickling in 2.6 and improved robustness of UUID system while …
6e8b240 
…maintaining support for 2.5

Signed-off-by: luka <luka@neuralmagic.com>
@ProExpertProg ProExpertProg force-pushed the luka/pass-manager-uuid-fix branch from 9cc9c2d to 6e8b240 Compare March 20, 2025 20:23
aarnphm
aarnphm reviewed Mar 20, 2025
View reviewed changes
aarnphm
aarnphm reviewed Mar 20, 2025
View reviewed changes
bnellnm
bnellnm approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ProExpertProg
Fix redef
bb23aec 
Signed-off-by: luka <luka@neuralmagic.com>
@ProExpertProg
Use importlib for __version__
7ec2665 
Signed-off-by: luka <luka@neuralmagic.com>
@ProExpertProg ProExpertProg requested a review from aarnphm March 20, 2025 20:55
houseroad
houseroad reviewed Mar 20, 2025
View reviewed changes
houseroad
houseroad reviewed Mar 20, 2025
View reviewed changes
youkaichao
youkaichao approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, approve to unblock

aarnphm
aarnphm reviewed Mar 21, 2025
View reviewed changes
aarnphm
aarnphm approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished the sanity check, and this works! Thanks

@aarnphm
Copy link
Collaborator

aarnphm commented Mar 21, 2025

cc @ProExpertProg for the pre-commit fix.

The entrypoints failure seems irrelevant.

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 21, 2025 21:08
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 21, 2025
@ProExpertProg
extract CustomGraphPass
46b00cf 
Signed-off-by: luka <luka@neuralmagic.com>
auto-merge was automatically disabled March 23, 2025 22:30

Head branch was pushed to by a user without write access

@ProExpertProg
formatting
0d3feb1 
Signed-off-by: luka <luka@neuralmagic.com>
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 23, 2025 22:54
@robertgshaw2-redhat robertgshaw2-redhat merged commit f622dbc into vllm-project:main Mar 24, 2025
34 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@ProExpertProg @erictang000
[Fix] [torch.compile] Improve UUID system for custom passes (vllm-pro…
f7a8003 
…ject#15249)

Signed-off-by: luka <luka@neuralmagic.com>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@ProExpertProg @wrmedford
[Fix] [torch.compile] Improve UUID system for custom passes (vllm-pro…
d2fedbf 
…ject#15249)

Signed-off-by: luka <luka@neuralmagic.com>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@ProExpertProg @lulmer
[Fix] [torch.compile] Improve UUID system for custom passes (vllm-pro…
2066f2f 
…ject#15249)

Signed-off-by: luka <luka@neuralmagic.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ProExpertProg ProExpertProg deleted the luka/pass-manager-uuid-fix branch April 9, 2025 17:51
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@ProExpertProg @lk-chen
[Fix] [torch.compile] Improve UUID system for custom passes (vllm-pro…
0c8c359 
…ject#15249)

Signed-off-by: luka <luka@neuralmagic.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@ProExpertProg @shreyankg
[Fix] [torch.compile] Improve UUID system for custom passes (vllm-pro…
edfdd5d 
…ject#15249)

Signed-off-by: luka <luka@neuralmagic.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@ProExpertProg
[Fix] [torch.compile] Improve UUID system for custom passes (vllm-pro…
3fb4a0b 
…ject#15249)

Signed-off-by: luka <luka@neuralmagic.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad left review comments

@youkaichao youkaichao youkaichao approved these changes

@aarnphm aarnphm aarnphm approved these changes

@bnellnm bnellnm bnellnm approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot unpickle PostGradPassManager
6 participants
@ProExpertProg @aarnphm @youkaichao @houseroad @bnellnm @robertgshaw2-redhat