Skip to content

[Bugfix] Fix broken CPU quantization due to triton import #15038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

[Bugfix] Fix broken CPU quantization due to triton import #15038

merged 1 commit into from
Mar 18, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Mar 18, 2025 •
edited by github-actions bot
Loading

FIX #15030 (link existing issues this PR will resolve)

@Isotr0py
fix cpu quant
a412829 
Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py mentioned this pull request Mar 18, 2025
Closed
1 task
@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 18, 2025
@Isotr0py Isotr0py enabled auto-merge (squash) March 18, 2025 14:56
@DarkLight1337 DarkLight1337 added this to the v0.8.0 milestone Mar 18, 2025
@vllm-bot vllm-bot merged commit 179a619 into vllm-project:main Mar 18, 2025
43 of 48 checks passed
@Isotr0py Isotr0py deleted the fix-cpu-quant branch March 18, 2025 16:09
simon-mo pushed a commit that referenced this pull request Mar 18, 2025
@Isotr0py @simon-mo
[Bugfix] Fix broken CPU quantization due to triton import (#15038)
1a504af 
Signed-off-by: Isotr0py <2037008807@qq.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Isotr0py @lulmer
[Bugfix] Fix broken CPU quantization due to triton import (vllm-proje…
e0b02ea 
…ct#15038)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Isotr0py @shreyankg
[Bugfix] Fix broken CPU quantization due to triton import (vllm-proje…
f5f1eda 
…ct#15038)

Signed-off-by: Isotr0py <2037008807@qq.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[Bugfix] Fix broken CPU quantization due to triton import (vllm-proje…
1dcfb99 
…ct#15038)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Triton Dependency for CPU in case of Quantization
4 participants
@Isotr0py @jeejeelee @DarkLight1337 @vllm-bot