[Doc] Dockerfile instructions for optional dependencies and dev transformers #13699
Conversation
…formers Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
docs/source/deployment/docker.md
Outdated
| ```Dockerfile | ||
| FROM vllm/vllm-openai:latest | ||
|
|
||
| RUN uv pip install --system vllm[audio,video] |
There was a problem hiding this comment.
this will install public latest released vllm, right? what if people build their own docker on a custom commit, and then just want to install these additional dependencies?
There was a problem hiding this comment.
Yes, that is correct. It is just an example, I'll add a comment telling users that they can change the base image as necessary.
There was a problem hiding this comment.
FROM vllm/vllm-openai:latest
you can change the base image here. but even if you change the base image,
RUN uv pip install --system vllm[audio,video]
this line will install the latest released version, it will not keep the current vllm in the docker.
There was a problem hiding this comment.
Oh, I see what you mean now... hmm, how can we only install the extras without the main package?
There was a problem hiding this comment.
Which license is it that's problematic? If we could find an alternative then we can package everything in the container
There was a problem hiding this comment.
Which license is it that's problematic? If we could find an alternative then we can package everything in the container
See #8030
There was a problem hiding this comment.
I don't know either. maybe just add comment to explicitly mention this limitation?
Is the vLLM directory inside the Docker container? Perhaps we can pip install from it?
There was a problem hiding this comment.
I don't think it has the vllm directory. vllm/vllm-openai is for deployment, and vllm is installed as a pip package.
There was a problem hiding this comment.
Alright, to keep things simple I have included a specific version of vLLM in the example.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…formers (vllm-project#13699) Signed-off-by: Linkun Chen <github@lkchen.net>
FIX #12980
FIX #13675