-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Core] Faster logit_bias_logits_processor #13334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Xu Song <xusong.vip@gmail.com>
Signed-off-by: Xu Song <xusong.vip@gmail.com>
If |
Signed-off-by: Xu Song <xusong.vip@gmail.com>
@imkero Thanks for your suggestion, a new commit has been added, which avoid duplicated tensor copy. After this change, the time_cost is reduced to 0.01ms
|
Signed-off-by: Xu Song <xusong.vip@gmail.com>
Signed-off-by: Xu Song <xusong.vip@gmail.com>
Signed-off-by: Xu Song <xusong.vip@gmail.com>
This pull request has merge conflicts that must be resolved before it can be |
@njhill conflicts have been resolved. |
Changes
logit_bias_logits_processor
from106ms
to0.01ms
(whenlen(logit_bias)=10000
).logits.index_add_(0,logit_bias_index, logit_bias_value)
Impl history
Performance
before -> v1 -> v2/v3
experiment settings: