Skip to content

[Bugfix] Explicitly set LoRA triton kernel device #13043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Feb 10, 2025

FIX #12967 (link existing issues this PR will resolve)

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee requested a review from mgoin February 10, 2025 15:10
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that we will need to do this for all triton kernels. @fabianlim ran into this problem on Bamba as well (it uses triton kernels for the mamba mixer).

If we have to do this everywhere it will be easy to miss a spot. Is it possible to do this in the GPUModelRunner instead?

@jeejeelee
Copy link
Collaborator Author

Seems that we will need to do this for all triton kernels. @fabianlim ran into this problem on Bamba as well (it uses triton kernels for the mamba mixer).

If we have to do this everywhere it will be easy to miss a spot. Is it possible to do this in the GPUModelRunner instead?

Make sense, I will handling it ASAP

@jeejeelee jeejeelee closed this Feb 11, 2025
@jeejeelee
Copy link
Collaborator Author

#13027 can better solve this issue, so I close this one

@jeejeelee jeejeelee deleted the fix-triton-device branch February 11, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Triton error when initializing LLM(...) when enable_lora=True and cuda device != cuda:0
2 participants