Skip to content

Conversation

lucypham951
Copy link

@lucypham951 lucypham951 commented Feb 9, 2025

This PR fixes an issue where CUDA detection fails silently when an outdated
version of pynvml (<12.0) is installed. The previous implementation
swallowed the RuntimeError, leading to is_cuda=False even when CUDA
devices were available, leading to UnspecifiedPlatform --> NotImplementedError

  • To avoid overwriting higher-level's RuntimeError catches, decided to forcefully
    terminate when found version error.

Copy link

github-actions bot commented Feb 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@houseroad
Copy link
Collaborator

The issue should be solved by #12963. cc: @youkaichao

@DarkLight1337
Copy link
Member

Closing as superseded by #12963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants