Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squelch MLA warning for Compressed-Tensors Models #12704

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Feb 3, 2025

Purpose

  • Squelch MLA warning when loading compressed-tensors models
WARNING 02-03 14:14:32 config.py:1007] compressed-tensors MLA support requires fp8 activations and weights in group 'group
_0', but got activations type 'None' and weights type 'int'.
WARNING 02-03 14:14:32 config.py:1007]  Full config: {'config_groups': {'group_0': {'input_activations': None, 'output_act
ivations': None, 'targets': ['Linear'], 'weights': {'actorder': None, 'block_structure': None, 'dynamic': False, 'group_si
ze': 128, 'num_bits': 4, 'observer': 'mse', 'observer_kwargs': {}, 'strategy': 'group', 'symmetric': True, 'type': 'int'}}
}, 'format': 'marlin-24', 'global_compression_ratio': 1.8917232374233346, 'ignore': ['lm_head'], 'kv_cache_scheme': None, 
'quant_method': 'compressed-tensors', 'quantization_status': 'compressed', 'sparsity_config': {'format': 'dense', 'global_
sparsity': 0.4561021413812781, 'ignore': ['lm_head'], 'registry_requires_subclass': False, 'sparsity_structure': '2:4', 't
argets': ['Linear']}}

Changes

  • Use demorgans to invert final condition and place at the beginning to act as a guard before warnings

Testing

from vllm import llm
llm = LLM("neuralmagic/Sparse-Llama-3.1-8B-ultrachat_200k-2of4-quantized.w4a16")

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Copy link

github-actions bot commented Feb 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the quick catch and fix

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 3, 2025
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for the fix

FYI @kylesayrs the PR description looked a little messed up (It was just a header that said Purpose), so I edited it to add a small description. Could you take a look to make sure it looks good?

@tlrmchlsmth tlrmchlsmth mentioned this pull request Feb 3, 2025
6 tasks
@kylesayrs
Copy link
Contributor Author

@tlrmchlsmth Description updated

@simon-mo simon-mo merged commit 6dd5e52 into vllm-project:main Feb 3, 2025
46 of 51 checks passed
fxmarty-amd pushed a commit to fxmarty-amd/vllm that referenced this pull request Feb 7, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Felix Marty <felmarty@amd.com>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: saeediy <saidakbarp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants