Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Generate valid tool call IDs when using tokenizer-mode=mistral #12332

Merged
merged 19 commits into from
Feb 12, 2025
Merged

[Frontend] Generate valid tool call IDs when using tokenizer-mode=mistral #12332

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fe57236
Adds valid tool id generation
rafvasq Jan 22, 2025
d63a884
Fixes mistral id wording, adjusts logic, adds check for id
rafvasq Jan 24, 2025
8125f31
Move imports
rafvasq Jan 24, 2025
c491a17
Lints
rafvasq Jan 24, 2025
4968fa3
Merge branch 'main' into fix-mistral-tool-call
rafvasq Jan 28, 2025
588f0cc
Reuse MistralToolParser, add truncating ID logic and checks
rafvasq Jan 30, 2025
5c41728
Remove logging
rafvasq Jan 30, 2025
7a91290
Fix assignments, valuerror
rafvasq Feb 4, 2025
2d25e3a
Modify valueerror msg
rafvasq Feb 4, 2025
803acff
Refactor tool call id handling, remove validation
rafvasq Feb 4, 2025
d0d2118
Merge branch 'main' into fix-mistral-tool-call
rafvasq Feb 4, 2025
b61a391
Fix docstring quotes
rafvasq Feb 4, 2025
133be5e
Fix docstring
rafvasq Feb 4, 2025
97439f0
Merge branch 'fix-mistral-tool-call' of https://github.com/rafvasq/vl…
rafvasq Feb 4, 2025
1119c83
Remove whitespace
rafvasq Feb 4, 2025
a62b036
Fix arg
rafvasq Feb 4, 2025
222daf8
Add mistral tool use tests for valid ID
rafvasq Feb 5, 2025
4dee4e8
Clean up mistal tool test utils
rafvasq Feb 5, 2025
4491128
lints
rafvasq Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix docstring quotes 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
  • Loading branch information
@rafvasq
rafvasq committed Feb 4, 2025
commit b61a3912235f972c22cb22764efb935351dbba1c
2 changes: 1 addition & 1 deletion vllm/transformers_utils/tokenizers/mistral.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def maybe_serialize_tool_calls(request: ChatCompletionRequest):


def truncate_tool_call_ids(request: ChatCompletionRequest):
'''Truncates tool call IDs to a length of 9 for Mistral's ID requirements'''
"""Truncates tool call IDs to a length of 9 for Mistral's ID requirements"""
for i, message in enumerate(request.messages):
if message.get("role") == 'assistant':
tool_calls = message.get("tool_calls", [])
Expand Down