-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[VLM] Merged multi-modal processor for Pixtral #12211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: remi <remi@mistral.ai>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: remi <remi@mistral.ai>
41c423a
to
4af1716
Compare
Signed-off-by: remi <remi@mistral.ai>
Signed-off-by: remi <remi@mistral.ai>
Signed-off-by: remi <remi@mistral.ai>
Signed-off-by: remi <remi@mistral.ai>
Signed-off-by: remi <remi@mistral.ai>
#12767 should make it easier to pass the image token ID |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: remi <remi@mistral.ai>
Any update on this? |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: remi <remi@mistral.ai>
Signed-off-by: remi <remi@mistral.ai>
Signed-off-by: remi <remi@mistral.ai>
Signed-off-by: remi <remi@mistral.ai>
Evaluation against
I'm unable to run the eval on V1 because of CUDA re-initialization error. @youkaichao do you have any idea why this happens? |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 It's probably related to |
Running into issues on V1 - I'll debug
|
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python -m eval.run eval_vllm \
--model_name mistralai/Pixtral-12B-2409 \
--url http://0.0.0.0:8000/ \
--output_dir ~/tmp \
--eval_name docvqa
V0 main
{
"anls": 0.8834957820937713
}
V1 main
{
"anls": 0.8837985481702968
}
V0 this PR
{
"anls": 0.883626647676123
}
V1 this PR (by overriding in arg_utils)
{
"anls": 0.8837702579252248
}
Given the results are all close enough, this PR should be good to go! Thanks for the work!
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
V0 main
V1 main
V0 this PR
V1 this PR
|
Signed-off-by: remi <remi@mistral.ai> Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: remi <remi@mistral.ai> Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: remi <remi@mistral.ai> Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
This PR aims at implementing the merged multi-modal processor for Pixtral as an effort to contribute to the V1 re-arch for multi-modal models.
Additional changes (by @DarkLight1337 ):
flatten_2d_lists
to avoid unnecessary iteration