Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] use right truncation for non-generative tasks #12050

Merged
merged 2 commits into from
Jan 15, 2025
Merged

[Bugfix] use right truncation for non-generative tasks #12050

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
337758d
:bug: use right truncation for non-generative tasks
joerunde Jan 14, 2025
4ce2673
:test_tube: add simple truncation test
joerunde Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
🧪 add simple truncation test 
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
  • Loading branch information
@joerunde
joerunde committed Jan 14, 2025
commit 4ce26730b259063cf5960217ef3773e93bb34e27
7 changes: 7 additions & 0 deletions tests/entrypoints/llm/test_encode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,10 @@ def test_multiple_pooling_params(llm: LLM):
# pooling_params is None, default params should be applied
outputs = llm.encode(PROMPTS, pooling_params=None)
assert len(PROMPTS) == len(outputs)


@pytest.mark.skip_global_cleanup
def test_right_side_truncation(llm: LLM):
# Embeddings models should truncate the end of the prompt
tokenizer = llm.get_tokenizer()
assert tokenizer.truncation_side == "right"
Loading