Skip to content

[Bugfix] make moe_align_block_size compliable with cuda graph #12036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jinzhen-lin
Copy link
Contributor

@jinzhen-lin jinzhen-lin commented Jan 14, 2025

The moe_align_block_size is used by many moe models (e.g. DeepSeek-V3) but it is not compliable with cuda graph now. This PR fix it.

Reference: sgl-project/sglang@77d1210 sgl-project/sglang@6e53051

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jinzhen-lin
Copy link
Contributor Author

With cuda graph, the generation speed of DeepSeek-V3 (W4A16, 8*A100-80G, bs=1) increase from 5 tokens/s to 10 tokens/s.

Copy link

mergify bot commented Jan 19, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jinzhen-lin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 19, 2025
@jinzhen-lin
Copy link
Contributor Author

close this PR as I create a new PR with better moe_align_block_size, see #12222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant