Skip to content

[Doc] update docs for nightly benchmarks #12022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

[Doc] update docs for nightly benchmarks #12022

merged 2 commits into from
Aug 7, 2025

Conversation

andrewkchan
Copy link
Contributor

@andrewkchan andrewkchan commented Jan 14, 2025 •
edited by github-actions bot
Loading

Noticed the docs for the nightly benchmark seem to be out-of-date since #7412. Fix links to nonexistent files.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 14, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Apr 21, 2025
@mergify
Copy link

mergify bot commented Apr 21, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @andrewkchan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 21, 2025
@github-actions github-actions bot added unstale Recieved activity after being labelled stale and removed stale Over 90 days of inactivity labels Apr 22, 2025
@mergify mergify bot added the performance Performance-related issues label Jun 23, 2025
@hmellor
Copy link
Member

hmellor commented Jul 16, 2025

Hi @andrewkchan could you please merge from main and make sure the updated links are still correct? Thanks!

@andrewkchan
update docs for nightly
6449a86 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
@andrewkchan
more
d50bbee 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
@andrewkchan
Copy link
Contributor Author

Rebased. @hmellor

@mergify mergify bot removed the needs-rebase label Jul 23, 2025
hmellor
hmellor approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@vllm-bot vllm-bot merged commit 35171b1 into vllm-project:main Aug 7, 2025
14 checks passed
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@andrewkchan @jinzhen-lin
[Doc] update docs for nightly benchmarks (vllm-project#12022)
69ea93f 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
@andrewkchan @noamgat
[Doc] update docs for nightly benchmarks (vllm-project#12022)
e0a1bb0 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@andrewkchan @paulpak58
[Doc] update docs for nightly benchmarks (vllm-project#12022)
f4cd123 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@andrewkchan @diegocastanibm
[Doc] update docs for nightly benchmarks (vllm-project#12022)
4c470c3 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@andrewkchan @epwalsh
[Doc] update docs for nightly benchmarks (vllm-project#12022)
1db97d0 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@andrewkchan @amd-xiaoyu12
[Doc] update docs for nightly benchmarks (vllm-project#12022)
6105537 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@andrewkchan @zhewenl
[Doc] update docs for nightly benchmarks (vllm-project#12022)
30a939a 
Signed-off-by: Andrew Chan <andrewkchan.akc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

@khluu khluu Awaiting requested review from khluu

@comaniac comaniac Awaiting requested review from comaniac

@ywang96 ywang96 Awaiting requested review from ywang96

Assignees

No one assigned

Labels

ci/build force-merge performance Performance-related issues unstale Recieved activity after being labelled stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewkchan @hmellor @vllm-bot