Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypy] Pass type checking in vllm/inputs #11680

Merged
merged 15 commits into from
Jan 2, 2025
Merged

[mypy] Pass type checking in vllm/inputs #11680

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
677ea96
fix types for vllm/inputs
CloseChoice Jan 2, 2025
d83c674
fix ruff errors
CloseChoice Jan 2, 2025
100edcd
add is_token_inputs helper function
CloseChoice Jan 2, 2025
76240b2
apply isort
CloseChoice Jan 2, 2025
9510a93
reformat data.py
CloseChoice Jan 2, 2025
08788b7
fix typeguard types
CloseChoice Jan 2, 2025
3b8b5c6
reformat data
CloseChoice Jan 2, 2025
d6add6a
use typeis instead of typeguard
CloseChoice Jan 2, 2025
5986992
refactor vllm/inputs/data.py to use newly defined functions
CloseChoice Jan 2, 2025
25b1329
Revert "refactor vllm/inputs/data.py to use newly defined functions"
CloseChoice Jan 2, 2025
085a5c2
sort mypy function runs alphabetically
CloseChoice Jan 2, 2025
17254a9
just ignore errors
CloseChoice Jan 2, 2025
1b99238
Update tools/mypy.sh
CloseChoice Jan 2, 2025
2b7b4ad
Update vllm/inputs/data.py
CloseChoice Jan 2, 2025
4e246b8
fix indentation
CloseChoice Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typeguard types 
Signed-off-by: Tobias Pitters <tobias.pitters@gmail.com>
  • Loading branch information
@CloseChoice
CloseChoice committed Jan 2, 2025
commit 08788b7488aa0f807516ac14d52c60e876ff382d
6 changes: 3 additions & 3 deletions vllm/inputs/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class TokenInputs(TypedDict):

def is_token_inputs(
inputs: Union[TokenInputs,
MultiModalInputsV2]) -> TypeGuard[TokenInputs]:
"MultiModalInputsV2"]) -> TypeGuard[TokenInputs]:
"""
Helper function to make sure mypy narrows down the type to
TokenInputs.
Expand All @@ -188,8 +188,8 @@ def is_token_inputs(


def is_multimodal_inputs(
inputs: Union[TokenInputs, MultiModalInputsV2]
) -> TypeGuard[MultiModalInputsV2]:
inputs: Union[TokenInputs, "MultiModalInputsV2"]
) -> TypeGuard["MultiModalInputsV2"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"""
Helper function to make sure mypy narrows down the type to
MultiModalInputsV2.
Expand Down
Loading